fix(ls): filter quality wrong truncation#990
Conversation
fix(refacto-codebase): technical docs & sub folders
…aster--components--rtk chore(master): release 0.34.2
fix(refacto): wrappers for standardization, exit codes lexer tokenizer, constants, code clean
…aster--components--rtk chore(master): release 0.34.3
|
|
|
Hi @aeppling can you check this out, this is my first pr to the repo, thank you for your help |
|
hello @TropicalDog17 , valid for me, could you remove the cargo lockfile, toml version bump and .release-please-manifest.json from this please ? This should just aim ls.rs |
c988efe to
d2ecbdb
Compare
|
Yeah I've adjusted, my bad @aeppling |
|
Is it ready to merge @aeppling? |
|
was waiting for previous release, merged |
|
Thanks for the contribution :) |
Summary
Might fixes #948
Problem: The old code split ls -la lines on whitespace and used fixed column indices (parts[4] for size, parts[8..] for filename). This broke when owner/group names contained spaces, causing the columns to shift — sizes became 0 and date/time fragments leaked into filenames.
Fix: The new parse_ls_line() function uses a regex (LS_DATE_RE) to find the date field as a stable anchor, which allow correctly parsing.
Test plan
cargo fmt --all && cargo clippy --all-targets && cargo testpassed for old and newly added tests